Bad Week for Google Voice

Just when we thought we had Humpty Dumpty put back together again with a quick fix to the broken Google Voice CLI tool, gvoice, come two more problems. First, a FreePBX 2.10 update breaks the Google Voice module (fix below), and then word that the Asterisk 10.1.x release breaks gtalk and Google Voice (no fix in sight). Read on...



DO NOT APPLY THE NEW FREEPBX 2.10 UPDATES WITHOUT FIRST UPDATING YOUR VERSION OF GOOGLE VOICE FreePBX MODULE TO 0.7 (on the next page) OR applying the one line patch at the bottom of this page after logging into your server as root.

Special thanks to Andrew Nagy for the quick fix!

Philippe is working on it. Stand by...

Are you sure you're running the 0.6 module?? The error you posted on the FreePBX forum shows a problem at line 331. My 0.6 version doesn't get a match at that line number, and the 0.6 edition appears to check for the class existence.

You can download the 0.6 module from here.

Here is the fix:

Code:

function googlevoice_hookGet_config($engine) {
	global $ext;	
	if (!method_exists($ext, 'ext_senddtmf') && (!class_exists('ext_senddtmf'))) {
		class ext_senddtmf extends extension {
			var $digits;
			function ext_senddtmf($digits) {
				$this->digits = $digits;
			} 
			function output() {
				return 'SendDTMF('.$this->digits.')';
			}
		}
	}
}

Will this work with earlier FreePBX 2.10 or 2.9??

Yes. All I added was another class check.

Perfect. Thanks!!

Here's the one-line patch that needs to be applied. No harm if you accidentally run it more than once. Or you can download and apply the new module update on the next page...

Code:

sed -i "s/'ext_senddtmf')) {/'ext_senddtmf') \&\& (\!class_exists('ext_senddtmf'))) {/" /var/www/html/admin/modules/googlevoice/functions.inc.php

http://www.the159.com/googlevoice/googlevoice-0.7.0.tgz

Just so 'everyone' is aware. No one is responsible for this module. It was written by someone outside of FreePBX and sort-of became a joint effort between Tony (Schmooze), Moshe, Mikael, Philippe, MZB (Original Author) and I. So I wouldn't rely on updates as it's not at all fully supported, it could break in 2.11 and never be fixed again. So please, please, don't demand it to be fixed.

You're absolutely right. But we all appreciate the prompt effort this time around! Thanks, Andrew.

I Just Don't Get It

Interesting how breaking chan_gtalk apparently is in the Asterisk Dev Team's charter, but when it comes to fixing it... "chan_gtalk is an extended support module, and hence supported by the Asterisk community. Response times may reflect that."

Meanwhile back at the ranch, the Digium Dev Team has been busy crowing about Asterisk's Google Voice, Gtalk, Jabber, and XMPP integration in its rundown of the Top 10 Tricks for Asterisk.

I recognized the name, pretty sure it is the same candrews on this forum who has made himself useful on the superfecta project.

I setup a new system today and wondered what had gone wrong; found the googlevoice reference in the logs, showed up here, and it was already fixed.

Awesome.

Good old Ward you are way too polite. Wonderful how gv integration is held up as a shining beacon of light and then anonymous developers break it with no thought if their changes will impact on a very popular (yet dare we say.... unprofitable.....) feature.

Damn those black helicopters are flying overhead again but now they have a capital D on the side. hmmmm

Tom